[no-Jira] Remove Amplify caching #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://remove-amplify-caching.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against d3c5364 No significant changes found |
dr-bizz
approved these changes
Nov 22, 2024
canac
added
the
On Staging
Successful deploys to Amplify weren't being deployed, so stop caching .next/cache and start caching node_modules as recommended by https://docs.aws.amazon.com/amplify/latest/userguide/deploy-nextjs-app.html#build-setting-detection
canac
force-pushed
the
remove-amplify-caching
branch
from
2b9c60c to
99a7ade
Compare
|
It turns out that the issue was the autogenerated Amplify redirects redirecting requests to an old CloudFront deployment. I removed them, and everything works now. This PR isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent PRs (likely since the Next.js 13 upgrade and the migrating to Amplify Web Compute) are deploying in preview but the changes aren't showing up in production or staging. I'm trying removing caching of
.next/cacheand adding caching ofnode_modulesto match the Amplify configuration in the Next.js SSR docs.Testing
Checklist: