Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8453] Tasks infinite scroll no longer scrolls to bottom on opening Comments modal #1211

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 22, 2024

Description

Tasks on the contact no longer get reordered/removed when you click on a task comment.

The issue was reported, by multiple people. It happens when you are on a contact page and you have a lot of tasks, so not all of them are loaded on the initial load.

To test, follow the steps I lay out here in this Jira ticket on staging, and then on the preview deployment to see the fix.

Jira: MPDX-8453
Helpscout: https://secure.helpscout.net/conversation/2751620240/1252918?folderId=7296147

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac November 22, 2024 17:53
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Nov 22, 2024
Copy link
Contributor

Preview branch generated at https://HS-1263709-comments.d3dytjb8adxkk5.amplifyapp.com

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 22, 2024

I just thought the user I mentioned might not have the same amount of tasks on staging. If not, just create a contact and add about 30 tasks to it, to recreate the issue.

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against d3c5364

No significant changes found

@canac canac changed the title Tasks infinite scroll no longer scrolls to bottom on opening Comments modal [MPDX-8453] Tasks infinite scroll no longer scrolls to bottom on opening Comments modal Nov 22, 2024
@dr-bizz dr-bizz merged commit 5d87e66 into main Nov 22, 2024
19 checks passed
@dr-bizz dr-bizz deleted the HS-1263709-comments branch November 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants