-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8481] Health Indicator graph component #1217
base: health-indicator
Are you sure you want to change the base?
Conversation
Preview branch generated at https://8481-hi-report-graph.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the UI, just the code. I assume the test are failing due to production API isn't up to date with staging.
src/components/common/LegendReferenceLine/LegendReferenceLine.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/HealthIndicatorReport/HealthIndicatorGraph/HealthIndicatorGraph.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/HealthIndicatorReport/HealthIndicatorGraph/useGraphData.ts
Outdated
Show resolved
Hide resolved
@dr-bizz If you want to look at the UI, just add this to the dashboard component (or any other page). <Grid xs={12} item>
Health Indicator
<HealthIndicatorGraph accountListId={accountListId} />
</Grid>
Yes, hopefully Justin can get a code review for his PR soon. |
window.ResizeObserver is undefined, so there is no reason to mock it sometimes and restore it afterwards.
e3940ad
to
31a2a39
Compare
Description
The first 6 commits build the foundation for creating the HI graph component. Mostly, it refactors and extracts existing code and components to be reusable within the HI graph. It also fixes autocomplete in
.graphql
files in VS Code by adding agraphql.config.json
file. I removed thewindowResizeObserver
file becausewindow.ResizeObserver
always starts out asundefined
. There's no reason to temporarily overwrite and restorewindow.ResizeObserver
, so I moved the mock code intosetup.ts
so that it always runs and the mock is available to all tests.The remaining commits implement the Health Indicator graph. The report that will contain the graph doesn't exist yet, so in testing, I temporarily added it to the dashboard:
@dr-bizz I created a
health-indicator
branch that is currently at the same commit asmain
that we can use to merge our PRs into. If you're OK with it, we can merge this PR first and then as you build out the report page, we can make tweaks to this component as needed in future PRs. Unless you know of changes I'll need to make to make this graph usable on your report page.MPDX-8481
Checklist: