Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8481] Health Indicator graph component #1217

Open
wants to merge 9 commits into
base: health-indicator
Choose a base branch
from

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 6, 2024

Description

The first 6 commits build the foundation for creating the HI graph component. Mostly, it refactors and extracts existing code and components to be reusable within the HI graph. It also fixes autocomplete in .graphql files in VS Code by adding a graphql.config.json file. I removed the windowResizeObserver file because window.ResizeObserver always starts out as undefined. There's no reason to temporarily overwrite and restore window.ResizeObserver, so I moved the mock code into setup.ts so that it always runs and the mock is available to all tests.

The remaining commits implement the Health Indicator graph. The report that will contain the graph doesn't exist yet, so in testing, I temporarily added it to the dashboard:

<Grid xs={12} item>
  Health Indicator
  <HealthIndicatorGraph accountListId={accountListId} />
</Grid>

@dr-bizz I created a health-indicator branch that is currently at the same commit as main that we can use to merge our PRs into. If you're OK with it, we can merge this PR first and then as you build out the report page, we can make tweaks to this component as needed in future PRs. Unless you know of changes I'll need to make to make this graph usable on your report page.

MPDX-8481

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Dec 6, 2024
@canac canac requested a review from dr-bizz December 6, 2024 20:34
@canac canac self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview branch generated at https://8481-hi-report-graph.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the UI, just the code. I assume the test are failing due to production API isn't up to date with staging.

@canac
Copy link
Contributor Author

canac commented Dec 9, 2024

I haven't tested the UI, just the code.

@dr-bizz If you want to look at the UI, just add this to the dashboard component (or any other page).

<Grid xs={12} item>
  Health Indicator
  <HealthIndicatorGraph accountListId={accountListId} />
</Grid>

I assume the test are failing due to production API isn't up to date with staging.

Yes, hopefully Justin can get a code review for his PR soon.

@canac canac force-pushed the 8481-hi-report-graph branch from e3940ad to 31a2a39 Compare December 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants