-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HS-1272111 Add Address Auto-Fill bug #1230
Conversation
Preview branch generated at https://HS1272111-address-autofill.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 7e667dd No significant changes found |
Code looks good! I'll test it when I'm back at my desk. Can you add a code comment explaining why we need the |
Do we need the same logic in |
I think it works if you remove the timeout and change the onChange={(_event, newValue) => {
if (typeof newValue === 'string') {
onStreetChange(newValue);
} else {
onStreetChange(newValue.description); // add this line
handlePlaceChosen(newValue);
}
}} The problem was that the autocomplete's text was getting out of sync with Formik. Adding the extra Can you try that and let me know if it works for you in your testing? |
@canac that works! good catch! |
f3851a4
to
e830e24
Compare
Description
https://secure.helpscout.net/conversation/2787902057/1272111?viewId=7669074
Checklist: