[No-Jira] Upgrade Apollo Server 4

[caleballdrin]

Description

Upgrade to Apollo Server 4

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://upgrade-apollo-server-v4.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 21a6276

No significant changes found

[dr-bizz]

Thank you for being willing to take this on! This needed to happen.
We should wait to push this live until the new year when everyone is back. I would hate for people to be called away from family to fix an error.

On a quick review, you should remove the old packages. They're also comments in the graphql-rest.page.ts page that are related to these packages, which need to be removed.

apollo-server-micro
apollo-datasource-rest

You could use the depcheck NPM package to find others that aren't used.

[canac]

This looks pretty good in my basic testing! In addition to removing the packages Daniel mentioned, you also need to run yarn and commit the changes it makes.

[canac]

On a quick review, you should remove the old packages.

apollo-server-micro apollo-datasource-rest

You could use the depcheck NPM package to find others that aren't used.

You should also be able to remove micro because it is a peer dependency of apollo-server-micro and won't be needed after removing apollo-server-micro.

[caleballdrin]

you also need to run yarn and commit the changes it makes.

@canac I ran yarn and there aren't any changes to commit.

[dr-bizz]

This is looking Great! I've reviewed some of the delete requests and they are working.

Thank you for removing the old dependencies and upgrading Apollo.

[dr-bizz]

I would also wait to get Caleb's review, and then when you deploy it, ensure you are around for the following 4-6 hours to ensure nothing breaks.

[canac]

I'm not seeing the warnings anymore in the console. Great work with this!

[canac]

This is good to go as far as I'm concerned!