-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-7935 add mailing address #955
Conversation
Bundle sizes [mpdx-react]Compared against a9d552f
|
@dr-bizz The code looks good! Now that you have the add address button you can remove the "MPDX" text. Could you also align the button with the address boxes? |
I also noticed that Tnt Imported addresses have a lock next to them. They should show an edit pen icon because they are editable. |
I don't think they should be editable, as they weren't before on the old MPDX. I think this is due to ensuring TNT is the only place people can update their info if it's imported from TNT. |
@dr-bizz Tnt addresses are editable in the old MPDX, it just also incorrectly shows a lock. There is no automatic update from Tnt like there is for Google and Siebel. Tnt import is more similar to a csv import where it is a one-time upload of data and then users will want to be able to edit that data in MPDX rather than going back to the csv/tnt file to re-import. |
@caleballdrin Fixed |
@dr-bizz I'm pretty sure Tnt is different than DataServer. If you look at Pedros account you can see my contact was imported from Tnt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@@ -233,7 +235,9 @@ const Contact: React.FC<Props> = ({ | |||
<strong>{t('Source')}: </strong> | |||
</Typography> | |||
</Hidden> | |||
<Typography display="inline">MPDX</Typography> | |||
<Typography display="inline"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dr-bizz Can you remove this? "MPDX" is still showing up across from the "Add Address" button. See my screenshot above.
Allow for TNT (DataServer) data to be edited in MPDX as it's imported once and not updated in third party software. Only MPDX, TNT and manually address are now editable Fixing failing test due to new changes with what source can be edited
6343904
to
7893bf6
Compare
Description
In this PR, I added a model for adding a mailing address, cleaned up the add button, and made some improvements to
AddAddressModal
, which I then did onEditContactAddressModal
. I've also added tests for editing, deleting, and adding an address.I also cleaned up the FixMailingAddress component, switched the modal state props to separate state values, and refactored the modal open/close handling.
Checklist: