Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7999 - Fix Amplify previews build #964

Merged
merged 2 commits into from
Jun 24, 2024
Merged

MPDX-7999 - Fix Amplify previews build #964

merged 2 commits into from
Jun 24, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 20, 2024

Description

Amplify Previews are currently not building and deploying due to an error when building.

The error is because we're hitting the staging API when building the GraphQL and since our graphQL doesn't have the Task Phases changes in it, it causes an error.

Fix: Hit the production API when creating the GraphQL, then in the app call the staging API

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jun 20, 2024
Copy link
Contributor

Preview branch generated at https://previews-on-amplify.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against eb907de

No significant changes found

@dr-bizz dr-bizz added Preview Environment Add this label to create an Amplify Preview and removed Preview Environment Add this label to create an Amplify Preview labels Jun 20, 2024
Copy link
Contributor

Preview branch generated at https://previews-on-amplify.d3dytjb8adxkk5.amplifyapp.com

@dr-bizz dr-bizz force-pushed the previews-on-amplify branch from 4dbfdef to 8fd131e Compare June 24, 2024 19:26
@dr-bizz dr-bizz force-pushed the previews-on-amplify branch from 8fd131e to 8de6e05 Compare June 24, 2024 19:30
@dr-bizz dr-bizz requested review from caleballdrin June 24, 2024 19:31
Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks like the magic word 'export' fixed it?

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jun 24, 2024

Yes, plus I had to change the If statement some.

@dr-bizz dr-bizz merged commit f64dd8a into main Jun 24, 2024
18 checks passed
@dr-bizz dr-bizz deleted the previews-on-amplify branch June 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants