Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-7984 Creating Appeals Detail Page Structure #972

Closed
wants to merge 50 commits into from
Closed

MPDX-7984 Creating Appeals Detail Page Structure #972

wants to merge 50 commits into from

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 28, 2024 •
edited
Loading

Description

This PR creates the Appeals Detail page structure, including the ListHeader and filters. The page setup allows opening a contact drawer within the appeal details page and includes basic List and Flows pages with filtering functionality.

Changes

  • Updated [appealId] page to [[...appealId]] for comprehensive path capturing.
  • Implemented functionality to open a contact within an appeal detail page.
  • Created basic List and Flows pages.
  • Added filters for flows and list views.
  • Removed obsolete files.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz changed the base branch from main to MPDX-7948-rebuilding-the-ui June 28, 2024 20:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 3475d73

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/appeals/[[...appealId]] 105.27 KB added
/accountLists/[accountListId]/tools/appeals no change removed
/accountLists/[accountListId]/tools/appeals/[appealId] no change removed
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 54.65 KB +13.99 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 38.53 KB +9.69 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 140.19 KB +4.27 KB
../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel 104.94 KB +4.28 KB
../src/components/Tool/Appeal/DynamicAppealsDetailsPage.tsx -> ./AppealsDetailsPage 105.84 KB added
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow 54.65 KB added
../src/components/Tool/Appeal/InitialPage/DynamicAppealsInitialPage.tsx -> ./AppealsInitialPage 79.71 KB added
../src/components/Tool/Appeal/List/AppealsListFilterPanel/DynamicAppealsListFilterPanel.tsx -> ./AppealsListFilterPanel 2.58 KB added
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList 38.53 KB added

dr-bizz added 9 commits June 28, 2024 16:33
@dr-bizz dr-bizz force-pushed the MPDX-7948-creating-appeal-details-pages branch from 3db4914 to 150ef32 Compare June 28, 2024 20:34
@dr-bizz dr-bizz force-pushed the MPDX-7948-rebuilding-the-ui branch from 3f10ca1 to 3c2975b Compare July 1, 2024 13:50
Base automatically changed from MPDX-7948-rebuilding-the-ui to main July 1, 2024 13:54
dr-bizz added 15 commits July 1, 2024 09:59
@dr-bizz
Merge branch 'main' into MPDX-7948-creating-appeal-details-pages
ef54887
@dr-bizz
Moved old files to different folder
b5e291a
@dr-bizz
Moving files to folders to make it easier to read
27f9d5b
@dr-bizz
Details layout and list layout
c41718f
@dr-bizz
Fixing List filters. Grab total amount and show skeletons
094c06c
@dr-bizz
Fixing issues flagged by console or styling issues found when navigat…
c1e3f5d 
…ing site
@dr-bizz
Allow the contact drawer to open without error. Needed to pass down c…
067396e 
…ontext so the components know which context to call.
@dr-bizz
Updating the contacts list infinite scroll query to call contacts ins…
e63914d 
…tead of appealContacts as contacts has more filtering options.
@dr-bizz
Fixing error with not passing the whole appealId (Url array made up o…
33dfc76 
…f appealID, listView and contactId). This was breaking AppealsContext.tsx
@dr-bizz
Fixing mailingAddress graphQL error as two mutations were called the …
9283ad0 
…same
@dr-bizz
Exporting contacts components so we don't have to duplicate code when…
a81ca67 
… creating the Tools contact components.
@dr-bizz
Updating the contactsList on appeals to use the Contacts query instea…
26de8c6 
…d of AppealContacts
@dr-bizz
Adding AppealStatusEnum on appealsContext ti use proper names.
470c6f1
@dr-bizz
Adding Appeal contact flow components. Importing certain components f…
bc96f42 
…rom contacts to reduce code maintenance.
@dr-bizz
Fixing lint:ts issues
ad54fa4
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jul 23, 2024

I need to fix things on this PR, so this isn't ready for a review

dr-bizz added 26 commits July 25, 2024 17:09
@dr-bizz
Fixing contacts tests
b03235d
@dr-bizz
Appeal Header tests
7001805
@dr-bizz
Appeal Wrapper and navigation tests
e6fb8c8
@dr-bizz
Appeal's and Contact's ContactRow component now share child component…
9e925c3 
…s and similar tests. I've added better tests and more of them.
@dr-bizz
Appeal Process Bar tests
7d67401
@dr-bizz
Appeal Details tests and clean up
c41af11
@dr-bizz
Very small clean up of 2 test files
4bbee4d
@dr-bizz
List view filter panel tests
10041f5
@dr-bizz
Adding Appeal mock data. Also removed AppealsContext as it was unused
d7e32e2
@dr-bizz
Contact Flow Column test
c03b096
@dr-bizz
Contact Flow and drag an drop tests
ca7c427
@dr-bizz
ContactContext tests
945c0c1
@dr-bizz
fixup! Appeal Wrapper and navigation tests
b89df5f
@dr-bizz
fixup! Details layout and list layout
fa65878
@dr-bizz
fixup! Appeal Process Bar tests
bb5eeb1
@dr-bizz
fixup! ContactContext tests
8de52fe
@dr-bizz
fixup! Setting up Appeals to open up appeals and open up contacts. /a…
d99d820 
…ppeals/appealId/flows/contactId
@dr-bizz
fixup! Adding Appeal contact flow components. Importing certain compo…
ee7a435 
…nents from contacts to reduce code maintenance.
@dr-bizz
fixup! Fixing List filters. Grab total amount and show skeletons
c999e16
@dr-bizz
fixup! Adding Appeal contact flow components. Importing certain compo…
ef6a70e 
…nents from contacts to reduce code maintenance.
@dr-bizz
fixup! ContactContext tests
4c6c898
@dr-bizz
fixup! Appeal Details tests and clean up
13325f1
@dr-bizz
fixup! List view filter panel tests
5a3ba3c
@dr-bizz
Deleted old files
48125a7
@dr-bizz
fixup! List view filter panel tests
c3fd565
@dr-bizz
fixup! Fixing mailingAddress graphQL error as two mutations were call…
cbc2256 
…ed the same
@dr-bizz dr-bizz closed this Jul 30, 2024
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Jul 30, 2024

New PR Here- #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dr-bizz