Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8024 - Fix Send Newsletter - Confirm All Button #983

Merged
merged 7 commits into from
Aug 12, 2024
Merged

MPDX-8024 - Fix Send Newsletter - Confirm All Button #983

merged 7 commits into from
Aug 12, 2024

Conversation

wrandall22
Copy link
Contributor

@wrandall22 wrandall22 commented Jul 25, 2024 •
edited
Loading

Description

This PR implements the Confirm All button for the Fix Send Newsletter tool.
Jira

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wrandall22 wrandall22 added Waiting on another PR This PR requires approval of another to be completed Preview Environment Add this label to create an Amplify Preview labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://MPDX-8024-confirm-all.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 0351b4f

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixSendNewsletter/[[...contactId]] 111.25 KB +1.52 KB

Base automatically changed from MPDX-7535-fix-newsletter-confirm to main July 31, 2024 15:22
@wrandall22 wrandall22 requested a review from dr-bizz August 1, 2024 20:23
@wrandall22
Copy link
Contributor Author

I still need to resolve the conflicts around renaming the graphql

@wrandall22 wrandall22 removed the Waiting on another PR This PR requires approval of another to be completed label Aug 1, 2024
@wrandall22 wrandall22 force-pushed the MPDX-8024-confirm-all branch from dbac87b to a2e5d0b Compare August 2, 2024 19:19
@wrandall22 wrandall22 requested review from caleballdrin and dr-bizz and removed request for dr-bizz and caleballdrin August 2, 2024 19:20
dr-bizz
dr-bizz requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this one. I have a few comments. Caleb C has also made edits to this page, so there will be merge conflicts for one of you to solve. But I am willing to help with the merge conflicts.

src/components/Tool/FixSendNewsletter/FixSendNewsletter.tsx Outdated Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/FixSendNewsletter.test.tsx Outdated Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/FixSendNewsletter.test.tsx Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
@wrandall22 wrandall22 requested a review from dr-bizz August 9, 2024 19:01
dr-bizz
dr-bizz approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this

@wrandall22
Copy link
Contributor Author

Thanks for reviewing!

@wrandall22 wrandall22 merged commit 2dd9c53 into main Aug 12, 2024
18 checks passed
@wrandall22 wrandall22 deleted the MPDX-8024-confirm-all branch August 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrandall22 @dr-bizz