Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8044 Fix Send Newsletter - add pagination #996

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

(https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8044#)

  • Added InfiniteList
  • Added more data (full address, email link and opted out of email)
  • Improved styles to match other pages.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin requested a review from dr-bizz August 7, 2024 06:34
@caleballdrin caleballdrin self-assigned this Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Bundle sizes [mpdx-react]

Compared against e8dc8c1

Route Size (gzipped) Diff
/accountLists/[accountListId]/tools/fixSendNewsletter/[[...contactId]] 114.09 KB +2.83 KB
/accountLists/[accountListId]/tools/mergeContacts/[[...contactId]] 118.29 KB +1.38 KB
/accountLists/[accountListId]/tools/mergePeople/[[...contactId]] 117.64 KB +1.38 KB

@caleballdrin
Copy link
Contributor Author

You can use TTM John Doe Exclusive to test this. It has many Newsletters to fix.

@caleballdrin caleballdrin requested a review from dr-bizz August 9, 2024 01:53
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I requested some changes but nothing much. Great work on this.

src/components/InfiniteList/InfiniteList.tsx Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
},
},
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check that the contact gets removed from the page after a successful request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm using refetchQueries it is hard to test that an item was removed. Because refetchQueries brings in the same mock data. Do you have any ideas on how to test this?

Copy link
Contributor

@dr-bizz dr-bizz Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the test is too hard, move onto the next item and leave a comment. We can come back.

@caleballdrin caleballdrin requested a review from dr-bizz August 9, 2024 16:15
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I'm going to approve this. It has some minor changes required, but I will not prevent you from deploying.

src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
src/components/Tool/FixSendNewsletter/Contact.tsx Outdated Show resolved Hide resolved
@caleballdrin caleballdrin merged commit 4207200 into main Aug 13, 2024
18 checks passed
@caleballdrin caleballdrin deleted the send-newsletter-pagination branch August 13, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants