Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Sort import statements and members #829

Merged
merged 5 commits into from
Dec 5, 2023
Merged

[no-Jira] Sort import statements and members #829

merged 5 commits into from
Dec 5, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 29, 2023

Description

Standardize import order. react first, then all libraries, then imports from the root directory, then parents, then siblings.

I only made changes to .eslintrc.js and ran yarn lint until all errors were fixed, so you shouldn't necessarily need to manually review every changed line.

@dr-bizz Do you have any suggestions or improvements to this sort order?

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz November 29, 2023 22:29
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-829.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great wortk on this!! Thank you for doing this!.

I did wonder if we should also include next straight after react, as Next is such a key part of this repo. What are your thoughts?
I'll approve the changes anyway as it looks good.

@canac
Copy link
Contributor Author

canac commented Dec 4, 2023

@dr-bizz I can see a case for that and will move next to the top. Should we keep next-auth where it currently is? That's what I lean towards.

@dr-bizz
Copy link
Contributor

dr-bizz commented Dec 4, 2023

@dr-bizz I can see a case for that and will move next to the top. Should we keep next-auth where it currently is? That's what I lean towards.

That sounds good to me. Thank you!

@canac canac merged commit 6815918 into main Dec 5, 2023
15 checks passed
@canac canac deleted the import-order branch December 5, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants