Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we pass ?limit=0 when hitting the table endpoint, knowing that it is the default? #364

Open
dmonroy opened this issue Jul 5, 2019 · 0 comments

Comments

@dmonroy
Copy link
Contributor

dmonroy commented Jul 5, 2019

In a recent conversation with @malecki he mentioned that default value for limit parameter in querystring for /table/ endpoint is 0. We went to this conversation by looking at the problem that I described in #363.

When loading variables from table endpoint we are being explicit with the limit parameter, setting it to 0:

table = ds.follow("table", urlencode({
'limit': 0
}))

I know someone would say that Explicit is better than implicit, and I will usually agree with that if it wouldn't be that it seems to be causing the problem I described in #363, so we must either remove the default value or prevent it from causing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant