Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate StreamingDataset and MutableDataset #372

Open
jamesrkg opened this issue Aug 8, 2019 · 5 comments
Open

Deprecate StreamingDataset and MutableDataset #372

jamesrkg opened this issue Aug 8, 2019 · 5 comments
Milestone

Comments

@jamesrkg
Copy link

jamesrkg commented Aug 8, 2019

These classes were implemented before Crunch had a dedicated attribute for streaming. Now that it does the distinction of these streaming states as dedicated classes is not needed. Instead, protected methods can reference the streaming flag directly.

This should be done prior to working on #370.

@jamesrkg jamesrkg added this to the Wishlist milestone Aug 8, 2019
@mathiasbc
Copy link
Contributor

This is doable in the short term.

@xbito
Copy link
Contributor

xbito commented Oct 30, 2019

We do want to provide some sort of compatibility layer. Probably concentrate methods in the Dataset class and continue having Streaming and Mutable as subclasses of it, but raise a DeprecationWarning when making an instance out of them.

@mathiasbc
Copy link
Contributor

Yes I was gonna propose a very similar thing. I should have a PR ready soon and we can discuss based off that.

@jamesrkg
Copy link
Author

Sounds good to me.

@mathiasbc
Copy link
Contributor

Initial PR: #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants