-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrunch compatibility with Python 3.11 #449
Comments
@jjdelc Any chance this can be looked at? We are trying to move our infrastructure to 3.11, this would allow us to have Crunch-related processes making a big step in that direction. Thanks. |
Hi Alex, currently this isn't in our short term priorities. I can't make that decision. If you have a PR that supports 3.6 and 3.11 we could verify and merge it. |
Hey JJ - Aamir (@shaikh-ma ) will soon, around Feb., take care of it then and make a PR. Aamir - let's chat again about it first! FYI @jamesrkg Cheers |
Ah, thanks for this! I just pushed version 0.17.0 with this new PR in it |
Thankyou! 🙂 |
Hello,
While attempting to use the
scrunch
library in one of my project running on Python 3.11 version, I found out that:The only module that is preventing it, is the
collections
module in the Python standard library.The methods
Mapping
&Iterable
had been moved to thecollections.abc
, in one of Python official versions.On making slight changes to the imports, I was able to use the scrunch library (0.16.1.dev0+g13c3de1.d20231124) in my Python 3.11 compatible project, without any issues, working as expected.
Below are the changes, which I have tried out,
In the
scrunch/datasets.py
module.scrunch/order.py
module.Please could you have a look and make the scrunch library compatible with Python 3.11, since the above point seems to be only thing blocking it, probably.
The text was updated successfully, but these errors were encountered: