Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider logs more beautify & add more informative new fields #155

Open
Dentrax opened this issue Jan 21, 2022 · 0 comments
Open

Consider logs more beautify & add more informative new fields #155

Dentrax opened this issue Jan 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link

Dentrax commented Jan 21, 2022

I'm not so sure how we can make the following logs much beautify, but here is what I'm proposing:

On New Announcement

Current:

New announcement detected: API3

New:

  • add announcement platform: KuCoin, Binance, etc.
  • add release time: Binance or KuCoin releaseDate timestamp field
  • add timestamp: there is a time-window between Bot <> Telegram Bot API until message dropped to channel
NEW: API3
Platform: KuCoin
Release: Fri Jan 21 2022 06:28:04
Timestamp: Fri Jan 21 2022 06:28:13

Current:

starting buy placeorder with : announcementcoin='API3' | globals.pairing='USDT' | volume=33.0 | amount=6.623845845042151 x price='4.982' | side = buy | status='cancelled'

New:

  • remove ='%s' wrappings
  • add total price: amount times price
  • add timestamp: see above
  • add at: there is a time-window between Bot <> Trading Platform. We should store timestamp before sending buy order to provider though API
Coin: API3
Action: BUY
Status: Cancelled
Pair: USDT
Volume: 33.0
Amount: 6.623845845042151
Price: 4.982
Total: {Amount x Price}
At: Fri Jan 21 2022 06:28:10
Timestamp: Fri Jan 21 2022 06:28:13

Current:

sold API3 with -1.534 profit | -3.031% PNL

New:

  • add % to profit
  • add total profit price according to pairing
  • add sold price
  • add timestamp: see above
  • add at: see above
Coin: API3
Action: SOLD
Price: 4.877
Profit: 3.245 USDT (-1.534%)
PNL: -3.031%
At: Fri Jan 21 2022 06:28:10
Timestamp: Fri Jan 21 2022 06:33:24
@Linus045 Linus045 added the enhancement New feature or request label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants