Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PE certificates against Certificate Revocation Lists #286

Open
sgaron-msft opened this issue Nov 12, 2024 · 1 comment
Open

Check PE certificates against Certificate Revocation Lists #286

sgaron-msft opened this issue Nov 12, 2024 · 1 comment
Assignees
Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request service-pe

Comments

@sgaron-msft
Copy link

Is your feature request related to a problem? Please describe.
Right now, the PE service only check is a PE is signed but does not validate if the certificate has been revoked.

Describe the solution you'd like
It would be very useful to have the PE service check the signature against the different revocation lists so the service would not provide a false sense of security to the user. We could also use this to mark file as malicious.

@sgaron-msft sgaron-msft added assess We still haven't decided if this will be worked on or not enhancement New feature or request labels Nov 12, 2024
@gdesmar gdesmar added accepted This issue was accepted, we will work on this at some point service-pe and removed assess We still haven't decided if this will be worked on or not labels Nov 12, 2024
@gdesmar gdesmar self-assigned this Nov 12, 2024
@gdesmar
Copy link

gdesmar commented Nov 12, 2024

https://crt.sh/ looks to be using Google's CRLSet, Microsoft's disallowedcert.stl, Mozilla's OneCRL and the specific cert's CA's CRL. That is a lot of CRLs that could be added as sources, and updated periodically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request service-pe
Projects
None yet
Development

No branches or pull requests

2 participants