Single auth - double sign-in

[eljeffeg]

Is your feature request related to a problem? Please describe.
We only support SAML authentication. When we hit the AssemblyLine page, we are met with this screen.

After you go through the SAML authentication, it takes you back to this unnecessary step, prompting you to "sign in".. again?

Once you click that, it signs you in.

Describe the solution you'd like
Just sign them in and forgo the second "sign-in" prompt when there is only one authentication method enabled.

[cccs-rs]

Hmm... could this be an issue if let's say you have access to multiple accounts using SAML/any OAuth service.

In a more general case, you'll likely only have one but I see the second sign-in as more of a confirmation of "Is this the user you want to sign in as or as a different user".

[eljeffeg]

Probably a low probability, but they could always just log out and sign in with the correct account in that situation. It's just sort of odd that it confirms the account I just logged into. Just log me in. If I didn't want that account, I should have logged in with the correct account - that's not on AssemblyLine, that's on me. Canadians.. too polite. 😂

[cccs-rs]

So the patch I've made so far will still display the first prompt with "Sign in with {provider}" but if there's only one provider configured on the system, it won't display the second prompt for confirmation before login.

You can test this with the latest dev release.

[cccs-rs]

This should be patched in the 4.5.0.63 release.

[eljeffeg]

I'm at v 4.5.0.68, but I still get the double login. My config looks like this with just saml enabled. Do I need to delete internal or put in entries for oath and set enabled: false?

configuration:
  auth:
    internal:
      # Disable internal login, you could also leave it on if you want
      enabled: false
    saml:
      # Should SAML authentication be enabled or not
      enabled: true
      ...

[cccs-rs]

Based on this commit:
CybercentreCanada/assemblyline-ui-frontend@133f9c9

It should remove the double login if you're using SAML with no other OAuth provider or if system is configured with exactly one OAuth provider. I don't think internal logins should affect the quick login.