Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_with_license dependency breaking change #37

Closed
k17trmeye opened this issue Jun 24, 2024 · 4 comments
Closed

make_with_license dependency breaking change #37

k17trmeye opened this issue Jun 24, 2024 · 4 comments

Comments

@k17trmeye
Copy link

With LicenseChoiceFactory class removed from license.py, the script generateBuildrootSBOM.py is not working as it utilizes the "make_with_license" function within LicenseChoiceFactory class.

@ptdropper
Copy link
Contributor

That used to work, I suspect a dependency issue. Will check on this, however work pressure is extreme for project delivery so I have little time to look.

@ptdropper
Copy link
Contributor

ptdropper commented Jun 27, 2024

My suspicion is that the dependency on the Cyclonedx Python library cyclonedx-python-lib = "^4.1" should be changed from "^4.1" to exactly 4.1 in the file pyproject.toml at line 15. I have not tried it but I know for certain that the make_with_license is a function in that library, and that I helped Jan K. with testing his library. If you would like to try @k17trmeye on your local build environment and let me know the results, that will help. I can give it a try once I get back to my development machine at home.

@ptdropper ptdropper changed the title generateBuildrootSBOM.py not working make_with_license dependency breaking change Jul 18, 2024
@ptdropper ptdropper linked a pull request Jul 21, 2024 that will close this issue
@ptdropper
Copy link
Contributor

Tracking the facts:
https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/CHANGELOG.md
BREAKING CHANGES
Dropped support for python<3.8 (CycloneDX/cyclonedx-python-lib#436 via CycloneDX/cyclonedx-python-lib#441; enable CycloneDX/cyclonedx-python-lib#433)
Reworked license related models, collections, and factories (CycloneDX/cyclonedx-python-lib#365 via CycloneDX/cyclonedx-python-lib#466)

@ptdropper
Copy link
Contributor

Corrected installation in pypi repo version 1.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants