From 4205e517ec020f9300f1f90dac71b132bf82cc7e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 7 Jan 2024 11:57:05 +0100 Subject: [PATCH] chore(deps-dev): bump c8 from 8.0.1 to 9.0.0 (#1006) * chore(deps-dev): bump c8 from 8.0.1 to 9.0.0 Bumps [c8](https://github.com/bcoe/c8) from 8.0.1 to 9.0.0. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](https://github.com/bcoe/c8/compare/v8.0.1...v9.0.0) --- updated-dependencies: - dependency-name: c8 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * fix deps Signed-off-by: Jan Kowalleck * fix deps in ci Signed-off-by: Jan Kowalleck --------- Signed-off-by: dependabot[bot] Signed-off-by: Jan Kowalleck Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jan Kowalleck --- .github/workflows/nodejs.yml | 16 ++++++++++++++-- package.json | 2 +- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e6f441af8..a7257ca82 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -134,12 +134,24 @@ jobs: shell: bash run: | set -ex - ## dont install all the dev-packages, especially since some are not runnable on node 14.0.0 + dep_constraints='' + dev_requirements='c8 mocha npm-run-all fast-glob' + # as long as npm cannot auto-resolve engine-constraints, we need to help here + case '${{ matrix.node-version }}' in + '14.0.0') + dev_requirements='c8@^8 mocha npm-run-all fast-glob' + ;; + esac + ## !! dont install all the dev-packages, especially since some are not runnable on node 14.0.0 + if [[ -n "$dep_constraints" ]] + then + npm add --ignore-scripts --omit=dev --only=prod --production --loglevel=silly --save $dep_constraints + fi npm i --ignore-scripts --include=optional --omit=dev --only=prod --loglevel=silly ## rebuild deps for which scripts were ignored, or partially installed - since "ignore-scripts" was used npm rebuild --loglevel=silly libxmljs2 || npm uninstall --no-save libxmljs2 ## install the needed dev-deps - npm i --no-save mocha c8 npm-run-all fast-glob + npm i --ignore-scripts --loglevel=silly --no-save $dev_requirements - name: fetch build artifact # see https://github.com/actions/download-artifact uses: actions/download-artifact@v3 diff --git a/package.json b/package.json index 5ac38cfc6..5232d6d68 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,7 @@ "@types/mocha": "^10", "@types/node": "ts5.3", "@types/spdx-expression-parse": "^3", - "c8": "8.0.1", + "c8": "^8||^9", "deepmerge": "^4.2.2", "eslint": "8.56.0", "eslint-config-standard": "17.1.0",