Upgradeable tank storages not changing when crafted together

[loving2]

Issue type:

• 🐛 Bug

---

Short description:

Steps to reproduce the problem:

1. Cheat in 2 Dark Tanks
2. Craft them together to try to increase their tank storage
3. Notice the tank storage value is unchanged

Expected behaviour:

The new Dark Tank should have an increased tank storage value equal to the storages of the 2 initial tanks combined.

---

Versions:

• This mod: 1.2.51
• Minecraft: 1.20.1
• Mod loader version: Forge 47.3.29

[rubensworks]

Thanks for reporting!

[Jack-McKalling]

Did you also test this with crafted tanks, not just creative ones? I believe there's some data on the item that you don't get from creative mode, which might affect merging tanks.

*Edit: nevermind, I can reproduce this too with both creative and survival methods.
Related even, the same thing applies to the large tank variant recipe. It gives the same 16buckets cap as the normal tank eventhough the recipe takes 9x the iron and dark gems.

[Jack-McKalling]

Curiously, none of these issues still happen in 1.21.1. So these fixes must not have been ported yet, or never happened in newer versions.