Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take care for action references that are submodules #39

Open
alex-ilgayev opened this issue Sep 17, 2023 · 0 comments
Open

take care for action references that are submodules #39

alex-ilgayev opened this issue Sep 17, 2023 · 0 comments
Labels
downloader Dowloader component (including GH API) good first issue Good for newcomers Low Priority

Comments

@alex-ilgayev
Copy link
Contributor

alex-ilgayev commented Sep 17, 2023

When we try to resolve the actions, and when there are relative paths, we try to resolve these paths into absolute paths and download the referenced action.

Sometimes the resolved absolute path is referencing a submodule. We aren't aware of that, and try to download the file which means nothing.

A real-world example:
This is part of ci.yml file for apache/airflow repository:

- name: Configure AWS credentials
  uses: ./.github/actions/configure-aws-credentials
  if: >
    github.ref == 'refs/heads/main' && github.repository == 'apache/airflow' &&
    github.event_name == 'push'

the configure-aws-credentials is actually a submodule, so we are unable to find the action.yml file beneath it (even though he exists in the submodule)

This is how raven logs looks like:

[+] Found 6 workflows for apache/airflow
[+] Fetching build-images.yml
[+] Fetching ci.yml
[-] Couldn't download the action.yml for the dependent action referenced by './.github/actions/configure-aws-credentials' (Maybe runs a local action that was checked out previously? Maybe the action is executed through a Dockerfile?)
[-] Couldn't download the action.yml for the dependent action referenced by './.github/actions/github-push-action' (Maybe runs a local action that was checked out previously? Maybe the action is executed through a Dockerfile?)
@alex-ilgayev alex-ilgayev transferred this issue from another repository Sep 24, 2023
@oreenlivnicode oreenlivnicode added the good first issue Good for newcomers label Oct 1, 2023
@alex-ilgayev alex-ilgayev added the downloader Dowloader component (including GH API) label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Dowloader component (including GH API) good first issue Good for newcomers Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants