Support class-validator 0.12.x

[nolazybits]

I really like the fact you are leveraging existing class-validator.
I've been trying to have data generated for a model like this for instance

import { Fixture } from "class-fixtures-factory";
import { IsString } from "class-validator";

export abstract class ITest
{
    @IsString()
    public abstract name: string;

    @Fixture()
    public abstract age: number;
}

Sadly the name property is not generated. Only the one with the Fixture decorator.
Would you have a working example somewhere I could look at or is this a bug?

Do I need to map the class-validator metadataStore to the one used by this library at all?

Thanks for the library!

[CyriacBr]

Hello.
I actually forgot to support some of the basic class-validator decorators such as IsString. I just pushed an update (1.4.0) and that should work for now, thanks for letting me know!

However, keep in mind that I was wondering about a more efficient way to handle third-party decorators, so there may be missing support for some other decorators too. Feel free to let me know if there are other decorators from class-validator I should support.

Also I updated the README so you should read it again.

[nolazybits]

Thank you much for the fast answer.
I'll keep you posted and happy to create PRs too!
Thanks again.

[nolazybits]

I'm sorry but this same example is still not working with the new released version.

[nolazybits]

One thing is class-validator has been updated to 0.12.x where changes were introduce to the metadata store and how to get it. That might be the why? Would be good to add version range in your package.json on the class-validator 0.11.x and maybe (please) have a 1.5 version supporting class-validator >= 0.12.x

Thanks a lot!

[CyriacBr]

Yeah I updated class-validator and my tests break now. I'll have to look into that.
Thank you.

[CyriacBr]

So, it appears that since the 0.12 version, the decorators names are lost when stored. I opened an issue there.

So, unless they fix that, there'd be no way to know which decorators are used in your classes. So if you want to use class-fixtures-factory, you'd have to rollback to 0.11.x version. I'll add a disclaimer in the README.

[nolazybits]

I hope they'll fix this in class-validator🤞
Thanks again @CyriacBr for being so reactive 👍

[nolazybits]

@CyriacBr we have forked class-validator here
https://github.com/ts-revival/class-validator and merged some of the required PR to have this lib working post 0.12.0 again.

if you could provide maybe a version that uses @ts-revival/class-validator so we can start moving forward that would be awesome!

Thanks for this awesome lib again

[CyriacBr]

Hi @nolazybits . Sorry for the late reply, was kinda busy.
I'm going to look into a new release for this package next weekend so hopefully I'll see how to integrate your fix.