Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializedReactiveProperties Odin Inspector support #257

Open
devcube9 opened this issue Sep 5, 2024 · 4 comments
Open

SerializedReactiveProperties Odin Inspector support #257

devcube9 opened this issue Sep 5, 2024 · 4 comments

Comments

@devcube9
Copy link

devcube9 commented Sep 5, 2024

Thank you for developing this amazing framework.

Currently, when using SerializedReactiveProperties with Odin inspector, there is an error when changing their values in the inspector.

? fieldInfo.GetValue(attachedComponent)

Similar issues was found in UniRx here:

neuecc/UniRx#531
neuecc/UniRx#452

Unlike the issues in UniRx, fieldInfo is null in R3

@neuecc
Copy link
Member

neuecc commented Sep 5, 2024

thanks, I'll check it.

@neuecc
Copy link
Member

neuecc commented Sep 27, 2024

I've tested at Unity 6000.0.20f1 and Odin 3.3.1.8, maybe it works.
Can you check it for me?
Also, I would be grateful if you could provide the MonoBehaviour code for the case where it doesn't work.

@neuecc neuecc closed this as completed Oct 7, 2024
@devcube9
Copy link
Author

using R3;
using Sirenix.OdinInspector;
using UnityEngine;

class Test {
    [SerializeField] private SerializableReactiveProperty<int> reactiveProperty;
}

public class SerializableReactivePropertyOdinError : SerializedMonoBehaviour {

    [SerializeField] private Test test;

}

I tested again and found that it only throws an error when a SerializableReactiveProperty is nested inside a class

@neuecc
Copy link
Member

neuecc commented Oct 22, 2024

thanks, I'll check it again.

@neuecc neuecc reopened this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants