Fix null pointer exceptions after resuming Unity from iOS #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Cysharp#597 Add null reference checks and reinitialize references after resuming Unity to prevent null pointer exceptions in UniTask code snippets. * **AsyncUniTaskMethodBuilder.cs** - Add null reference checks in `SetResult`, `SetException`, `AwaitOnCompleted`, and `AwaitUnsafeOnCompleted` methods. * **PlayerLoopRunner.cs** - Add code to reinitialize references after resuming in `RunCore` method. * **PlayerLoopHelper.cs** - Add code to ensure references are not lost after resuming in `AddAction` and `AddContinuation` methods. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Cysharp/UniTask/issues/597?shareId=XXXX-XXXX-XXXX-XXXX).
|
Your null reference check is designed to double-check for null in this way. if (runnerPromise == null)
{
ex = exception;
}
else
{
if (runnerPromise != null)
{
runnerPromise.SetException(exception);
}
}It says “open the Copilot Workspace session”, but is this fix being made using AI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597
Add null reference checks and reinitialize references after resuming Unity to prevent null pointer exceptions in UniTask code snippets.
SetResult,SetException,AwaitOnCompleted, andAwaitUnsafeOnCompletedmethods.RunCoremethod.AddActionandAddContinuationmethods.For more details, open the Copilot Workspace session.