Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH-1 Exlude mime4j depedencies via sword2 #197

Merged

Conversation

PaulBoon
Copy link

@PaulBoon PaulBoon commented Apr 17, 2024

Exlude mime4j depedencies via sword2, as they win out over the correct versions
Issue: IQSS#9077

What this PR does / why we need it:

Re-appying the PATCH-1 we had on version 6.0
Part of upgrading from 6.0 to 6.2
More patches are needed

Suggestions on how to test this:

Prepare a system with the patched version of Dataverse.

  1. First you need a server to deploy on; the Vagrant boxes we use need some updating before it will work.
    Use another PR on dans-core-systems (https://github.com/DANS-KNAW/dans-core-systems/pull/30) for that; it will provide for the following to update:
    start-preprovisioned-box.py -s dev_archaeology.
  2. Then fix the database, it contains a wrong flyway record:
    vagrant ssh dev_archaeology
    sudo -u postgres psql
    \c dvndb
    DELETE FROM flyway_schema_history WHERE script='V6.0.0.2__9983-missing-unique-constraints.sql';
    
  3. Deploy the update with the IQSS 6.2 version first:
    deploy.py --playbook provisioning/patches/upgrade-dataverse/to-6.2.yml dev_archaeology.
  4. Then deploy the war file of this PR, after a build mvnci. deploy.py --dataverse-war external/dataverse/target/dataverse.

Then test it with a file that would show the error if it was not fixed.

  1. Enable full text indexing:
    vagrant ssh dev_archaeology
    curl -X PUT -d true http://localhost:8080/api/admin/settings/:SolrFullTextIndexing
    
  2. Login, create a dataset and upload that file.
  3. Check that the Logs don't show that ERROR; Full-text indexing for email.txt failed due to Error: java.lang.NoClassDefFoundError : org/apache/james/mime4j/stream/MimeConfig$Builder.
  4. Check that the file has been indexed; search for 'peripatetic' should result in that file.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #48

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 20.718%

Totals Coverage Status
Change from base Build #47: 0.002%
Covered Lines: 17162
Relevant Lines: 82836

💛 - Coveralls

@PaulBoon PaulBoon merged commit ebdc88c into DANS-KNAW:v6.2-DANS-DataStation May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants