Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting FCS version 3.2 #5

Open
joseph-sch opened this issue Sep 23, 2021 · 3 comments
Open

Consider supporting FCS version 3.2 #5

joseph-sch opened this issue Sep 23, 2021 · 3 comments

Comments

@joseph-sch
Copy link
Contributor

I have just noticed that FCS standard version 3.2 has been published: https://pubmed.ncbi.nlm.nih.gov/32881398/ or http://flowcyt.sourceforge.net/fcs/fcs32.pdf

It is brand new and non-backward compatible so I don't suggest 'switching' altogether, but we should consider supporting users who will want to transition.

@paulmueller
Copy link
Member

I agree. I would be happy to review a PR (including tests). A kwarg fcs_version="3.0" (default for now) or fcs_version="3.2" would probably make sense.

@lin1996-ux
Copy link

Is there any chance to use the kwarg fcs_version in fcswrite.write_fcs(), if I need to write numpy data to a .fcs file in FCS2.0 file format?

@paulmueller
Copy link
Member

@lin1996-ux version 2.0 is not supported. The keyword fcs_version does not exist yet. Please create a new issue if you need that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants