Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLObject bug: identical seeds don't give same random values #115

Open
dccote opened this issue Aug 2, 2024 · 0 comments
Open

CLObject bug: identical seeds don't give same random values #115

dccote opened this issue Aug 2, 2024 · 0 comments

Comments

@dccote
Copy link
Contributor

dccote commented Aug 2, 2024

Describe the bug
The test kernel in random.c does not work when CLObject is used, but does work in testGeneralOpenCL.py when the basic PyOpenCL structures are used. There may be an error in CLObject.

To Reproduce
From the root directory, the test test_call_random_value_with_same_seeds_buffer_should_give_same_results for fillRandomFloatBuffer will fail:
python3 -m unittest pytissueoptics/rayscattering/tests/opencl/src/testCLProgram.py

but will succeed when using basic PyOpenCL structures (same test name: test_call_random_value_with_same_seeds_buffer_should_give_same_results):
python3 -m unittest pytissueoptics/rayscattering/tests/opencl/src/testGeneralOpenCL.py

Expected behavior
Using the same seeds twice should give the same random values, as demonstrated with the second successful tests

@dccote dccote assigned dccote and unassigned dccote Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant