Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

years only run to 2015 #131

Open
maxwell8888 opened this issue Nov 9, 2017 · 0 comments
Open

years only run to 2015 #131

maxwell8888 opened this issue Nov 9, 2017 · 0 comments
Assignees
@maxwell8888

Comments

@maxwell8888
Copy link
Contributor

update where necessary in package so that data runs to 2016 not just 2015. I am going to hardcode it and wait until dplyr is updated to make dynamic. although this might make some tests fail.
@maxwell8888 maxwell8888 self-assigned this Nov 9, 2017
maxwell8888 added a commit that referenced this issue Nov 9, 2017
@maxwell8888
fix issue #131
947ba96 
updated combine_GVA_long and GVA_by_sector to dynamically pick the year
but not year_sector_table because of the NSE syntax it is using which I
plan to change - in this case I had to supress the year_sector_table
unit tests, which I would replace at somepoint anyway with tests using
the dummy data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwell8888 maxwell8888

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxwell8888