Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path is undefined #4

Open
georgebutter opened this issue Oct 13, 2017 · 2 comments
Open

path is undefined #4

georgebutter opened this issue Oct 13, 2017 · 2 comments

Comments

@georgebutter
Copy link

georgebutter commented Oct 13, 2017

Hello, I'm not working from this repo, am just following along with the article you wrote and incorporating into a different project, so I may be wrong but I think I found a bug.

In this file the get request uses path.join but the path module hasn't been required and I couldn't see how else in could be included.

P.S Great article 👍

@jgibson02
Copy link

You should only need to add var path = require('path'); to your router.js.

@mboeser
Copy link

mboeser commented Jan 4, 2018

@ButsAndCats @jgibson02 I ran the app successfully as is without adding the path variable. I wanna say that I read somewhere that you no longer need to require the path module but am unable to find the URL to support it. I'm unsure why the app isn't crashing since path would be undefined at that line so perhaps one doesn't need to declare it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants