diff --git a/Makefile b/Makefile index fe3f290d..143c0cd1 100644 --- a/Makefile +++ b/Makefile @@ -211,8 +211,10 @@ domains: # make qa railsc .PHONY: railsc railsc: get-cluster-credentials - $(if $(env), , $(error Missing . Usage: "make railsc")) - kubectl -n $(azure_namespace) exec -ti deployment/teaching-vacancies-$(env) -- rails c + $(eval NAMESPACE_SUFFIX=$(shell echo $(AZURE_SUBSCRIPTION) | awk -F '-' '{print $$NF}')) + @echo "Using namespace: $(NAMESPACE_SUFFIX)" + @echo "Environment: $(CONFIG)" + kubectl -n tra-$(NAMESPACE_SUFFIX) exec -ti deployment/access-your-teaching-qualifications-$(CONFIG) -- rails c bin/konduit.sh: curl -s https://raw.githubusercontent.com/DFE-Digital/teacher-services-cloud/main/scripts/konduit.sh -o bin/konduit.sh \ diff --git a/README.md b/README.md index c371cc0d..629b56a9 100644 --- a/README.md +++ b/README.md @@ -226,14 +226,14 @@ The review app needs to be deployed first. You can do this manually by tagging a ### Updating keyvault secrets -Updating keyvault secrets is a manual process, the resource can be found in +Updating keyvault secrets is a manual process which will require elevated permissions via PIM for production access to Azure resources, the resource can be found in: ``` Review: s189t01-aytq-rv-app-kv Test: s189t01-aytq-ts-app-kv Preproduction: s189t01-aytq-pp-inf-kv -Produciton: s189p01-aytq-pd-app-kv +Production: s189p01-aytq-pd-app-kv ``` ## Licence diff --git a/docs/review_apps.md b/docs/review_apps.md index 310f2e26..0fc5e2f1 100644 --- a/docs/review_apps.md +++ b/docs/review_apps.md @@ -8,7 +8,9 @@ Both services are accessible at the single URL. By default, the base path will r In order to deploy a review app you can either use the make target or raise a pull request and label the deployment with 'deploy-aks' and this will trigger the GHA workflow to deploy the review app based on the branch name. -This will then create a URL for testing and to destroy the review app you close the pull request which will trigger the delete workflow. Further details for this can be found in the github workflow build-and-deploy.yml aswell as the deploy-environment/action.yml +This will then create a URL for testing and to destroy the review app when you close the pull request which will trigger the delete workflow. Further details for this can be found in the github workflow build-and-deploy.yml as well as the deploy-environment/action.yml. + +Note that review apps have container based Postgres and Redis volumes. The data will not persist once the review app has been destroyed. ## Authentication