From ea269efcaefc359d79fbe62f6fd436db00540e6c Mon Sep 17 00:00:00 2001
From: Felix Clack <felixclack@gmail.com>
Date: Fri, 27 Sep 2024 15:26:00 +0100
Subject: [PATCH] Fix the count of records

When counting the total number of searched records, we are incorrectly
using the paged values.

This change ensures we count the total records before applying
pagination.
---
 app/controllers/check_records/bulk_searches_controller.rb | 2 ++
 app/views/check_records/bulk_searches/show.html.erb       | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/controllers/check_records/bulk_searches_controller.rb b/app/controllers/check_records/bulk_searches_controller.rb
index 0398352e..d839cebf 100644
--- a/app/controllers/check_records/bulk_searches_controller.rb
+++ b/app/controllers/check_records/bulk_searches_controller.rb
@@ -40,6 +40,8 @@ def show
 
       data = @bulk_search_response.body
       @total = @bulk_search_response.total
+      @total_not_found = data['not_found'].count
+      @total_results = data['results'].count
       @results ||= data.fetch("results", []).map do |teacher|
         QualificationsApi::Teacher.new(teacher['api_data'])
       end
diff --git a/app/views/check_records/bulk_searches/show.html.erb b/app/views/check_records/bulk_searches/show.html.erb
index 826102a2..5e8907d1 100644
--- a/app/views/check_records/bulk_searches/show.html.erb
+++ b/app/views/check_records/bulk_searches/show.html.erb
@@ -1,14 +1,14 @@
 <% content_for :page_title, "Bulk Search Results" %>
 <% content_for :breadcrumbs do %>
   <%= govuk_breadcrumbs(breadcrumbs: { "Home" => check_records_search_path, "Find multiple records" => new_check_records_bulk_search_path, "Results" => nil }) %>
+  <%= render ActionAtComponent.new(action: "searched") %>
 <% end %>
 
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-full">
-    <%= render ActionAtComponent.new(action: "searched") %>
     <h1 class="govuk-heading-l"><%= pluralize(@total, 'teacher record') %> found</h1>
     <p class="govuk-body govuk-!-margin-bottom-6">
-      We found <%= pluralize(@total, 'teacher record') %> out of the <%= pluralize(@results.count + @not_found.count, 'entry') %> you uploaded.
+      We found <%= pluralize(@total, 'teacher record') %> out of the <%= pluralize(@total_results + @total_not_found, 'entry') %> you uploaded.
     </p>
     <%= govuk_tabs do |tabs|
       if @results.any?