From a8391aa11403a03702321540683003d7e1d7853a Mon Sep 17 00:00:00 2001 From: Avin Hurry Date: Thu, 12 Dec 2024 13:01:19 +0000 Subject: [PATCH] Shorten the PR template checklist This list has grown quite long over time, some items are quite basic and are just considered good practice, others are duplicated, so we shouldn't have to read through them every time. --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 578e7f2070f..b4c18543e14 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -15,14 +15,8 @@ - [ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database - [ ] This code does not rely on migrations in the same Pull Request - [ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency -- [ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist +- [ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes - [ ] If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated. - [ ] API release notes have been updated if necessary - [ ] If it adds a significant user-facing change, is it documented in the [CHANGELOG](CHANGELOG.md)? -- [ ] Required environment variables have been updated [added to the Azure KeyVault](/docs/environment-variables.md#deploy-pipeline) -- [ ] Inform data insights team due to database changes -- [ ] Make sure all information from the Trello card is in here -- [ ] Rebased main -- [ ] Cleaned commit history -- [ ] Tested by running locally -- [ ] Add PR link to Trello card +- [ ] Attach the PR to the Trello card