From 1d507cd31638183b2eac272b24b32d2e07f1fcaf Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Tue, 3 Dec 2024 15:19:18 +0000 Subject: [PATCH] fix new linting issues --- lib/csv_importer/base.rb | 2 +- spec/models/payment_confirmation_upload_spec.rb | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/csv_importer/base.rb b/lib/csv_importer/base.rb index f5dbfb3b81..7db28c5ba6 100644 --- a/lib/csv_importer/base.rb +++ b/lib/csv_importer/base.rb @@ -60,7 +60,7 @@ def delete_all_scope end def with_headers? - parse_headers && mandatory_headers&.is_a?(Array) && mandatory_headers&.any? + parse_headers && mandatory_headers&.is_a?(Array) && mandatory_headers.any? end def check_headers diff --git a/spec/models/payment_confirmation_upload_spec.rb b/spec/models/payment_confirmation_upload_spec.rb index 6539038415..97388e0472 100644 --- a/spec/models/payment_confirmation_upload_spec.rb +++ b/spec/models/payment_confirmation_upload_spec.rb @@ -90,10 +90,10 @@ gross_value: "487.48".to_d, national_insurance: "33.9".to_d, employers_national_insurance: "38.98".to_d, - student_loan_repayment: "0".to_d, - postgraduate_loan_repayment: "0".to_d, + student_loan_repayment: 0.to_d, + postgraduate_loan_repayment: 0.to_d, tax: "89.6".to_d, - net_pay: "325".to_d, + net_pay: 325.to_d, gross_pay: "448.5".to_d ) @@ -102,10 +102,10 @@ gross_value: "904.15".to_d, national_insurance: "77.84".to_d, employers_national_insurance: "89.51".to_d, - student_loan_repayment: "40".to_d, - postgraduate_loan_repayment: "0".to_d, + student_loan_repayment: 40.to_d, + postgraduate_loan_repayment: 0.to_d, tax: "162.8".to_d, - net_pay: "534".to_d, + net_pay: 534.to_d, gross_pay: "814.64".to_d ) @@ -114,9 +114,9 @@ gross_value: "11_027.46".to_d, national_insurance: "268.84".to_d, employers_national_insurance: "1316.63".to_d, - student_loan_repayment: "839".to_d, + student_loan_repayment: 839.to_d, postgraduate_loan_repayment: "9710.83".to_d, - tax: "1942".to_d, + tax: 1942.to_d, net_pay: "6660.99".to_d, gross_pay: "9710.83".to_d )