From 9ffa86a9b010abf280057ac25d1eabf993d4c72a Mon Sep 17 00:00:00 2001 From: Dominic NEED Date: Mon, 11 Dec 2023 15:59:03 +0000 Subject: [PATCH 1/2] Remove API calls in cypress --- .../e2e/Core-journeys/FormAMat-conversion.cy.js | 17 ----------------- .../Core-journeys/sponsored-conversion.cy.js | 2 +- .../Core-journeys/voluntary-conversion.cy.js | 7 ++----- 3 files changed, 3 insertions(+), 23 deletions(-) delete mode 100644 Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/FormAMat-conversion.cy.js diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/FormAMat-conversion.cy.js b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/FormAMat-conversion.cy.js deleted file mode 100644 index fde31bae4..000000000 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/FormAMat-conversion.cy.js +++ /dev/null @@ -1,17 +0,0 @@ -/// - -describe('Form a MAT conversion', { tags: ['@dev', '@stage'] }, () => { - beforeEach(() => { - cy.callAcademisationApi('POST', `cypress-data/add-form-a-mat-project.cy`, "{}") - .then(() => { - cy.login({ titleFilter: 'Cypress Project' }) - .then(() => { - cy.get('[id="school-name-0"]').click(); - }); - }); - }) - - it('TC01: Form a MAT conversion journey ', () => { - // Go wild Dan! - }) -}) \ No newline at end of file diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/sponsored-conversion.cy.js b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/sponsored-conversion.cy.js index 3169ef5d2..f12032332 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/sponsored-conversion.cy.js +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/sponsored-conversion.cy.js @@ -59,7 +59,7 @@ describe('Sponsored conversion journey', { tags: ['@dev', '@stage'] }, () => { } before(() => { - cy.callAcademisationApi('POST', `cypress-data/add-sponsored-project.cy`, "{}") + // Do the spin up a project journey }) beforeEach(() => { diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js index acefbc0ed..3b8899242 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js @@ -5,11 +5,8 @@ import voluntaryProjectTaskList from '../../pages/voluntaryProjectTaskList' var projectName = 'Voluntary Cypress Project' describe('Voluntary conversion', { tags: ['@dev', '@stage'] }, () => { - beforeEach(() => { - cy.callAcademisationApi('POST', `cypress-data/add-voluntary-project.cy`, "{}") - .then(() => { - projectList.selectProject(projectName) - }); + before(() => { + // Do the spin up a project journey }) it('TC01: Voluntary conversion journey ', () => { From de6d88a75ed2ca32200a77d91c59fd358604fbba Mon Sep 17 00:00:00 2001 From: Dominic NEED Date: Tue, 12 Dec 2023 09:19:42 +0000 Subject: [PATCH 2/2] Removed unused vars for linting purposes --- .../cypress/e2e/Core-journeys/voluntary-conversion.cy.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js index 3b8899242..5580f7ab2 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions.CypressTests/cypress/e2e/Core-journeys/voluntary-conversion.cy.js @@ -1,9 +1,6 @@ /// -import projectList from '../../pages/projectList' import voluntaryProjectTaskList from '../../pages/voluntaryProjectTaskList' -var projectName = 'Voluntary Cypress Project' - describe('Voluntary conversion', { tags: ['@dev', '@stage'] }, () => { before(() => { // Do the spin up a project journey