From b642af88c79211c7910f33b2e150a2dcf3632f54 Mon Sep 17 00:00:00 2001 From: Elijah Aremu <45821029+elielijah321@users.noreply.github.com> Date: Wed, 13 Dec 2023 14:06:00 +0000 Subject: [PATCH 1/6] update project list view --- .../Models/AcademyConversionProject.cs | 1 + .../Pages/ProjectList/Index.cshtml | 17 +---- .../Shared/FormAMatProjectListRow.cshtml | 39 ------------ .../Shared/SponsoredProjectListRow.cshtml | 46 -------------- .../Shared/VoluntaryProjectListRow.cshtml | 45 ------------- .../Pages/Shared/_ProjectListRows.cshtml | 63 +++++++++++++++++++ .../Utils/ProjectListHelper.cs | 3 +- .../ViewModels/ProjectListViewModel.cs | 1 + 8 files changed, 68 insertions(+), 147 deletions(-) delete mode 100644 Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/Shared/FormAMatProjectListRow.cshtml delete mode 100644 Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/Shared/SponsoredProjectListRow.cshtml delete mode 100644 Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/Shared/VoluntaryProjectListRow.cshtml create mode 100644 Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/Shared/_ProjectListRows.cshtml diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions.Data/Models/AcademyConversionProject.cs b/Dfe.PrepareConversions/Dfe.PrepareConversions.Data/Models/AcademyConversionProject.cs index 2cc9d77e9..df5cba080 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions.Data/Models/AcademyConversionProject.cs +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions.Data/Models/AcademyConversionProject.cs @@ -49,6 +49,7 @@ public class AcademyConversionProject public string ConversionSupportGrantEnvironmentalImprovementGrant { get; set; } public bool? ConversionSupportGrantAmountChanged { get; set; } public DateTime? DaoPackSentDate { get; set; } + public string Region { get; set; } // Annex B public bool? AnnexBFormReceived { get; set; } diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml b/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml index 4a70c624c..3ee232b4c 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml @@ -51,24 +51,9 @@
Application information | -Project status and dates | -
---|
-
- @Model.Item.Status.Value -
-
-
- Project created date: @Model.Item.CreatedOn.ToDateString()
-
-
- @("Advisory board date: " + Model.Item.HeadTeacherBoardDate)
-
-
- Opening date:
- @Model.Item.ProposedAcademyOpeningDate
-
-
-
- @Model.Item.Status.Value -
-
-
- Project created date: @Model.Item.CreatedOn.ToDateString()
-
-
- @("Advisory board date: " + Model.Item.HeadTeacherBoardDate)
-
-
- Opening date:
- EMPTY
- @Model.Item.ProposedAcademyOpeningDate
-
-
-
- @Model.Item.Status.Value -
-
-
- Project created date: @Model.Item.CreatedOn.ToDateString()
-
-
- @("Advisory board date: " + Model.Item.HeadTeacherBoardDate)
-
-
- Opening date:
- EMPTY
- @Model.Item.ProposedAcademyOpeningDate
-
-
+ + | @{ From 6916e7d80d3dd1fcaf2cc6af891f136313c5e315 Mon Sep 17 00:00:00 2001 From: Elijah Aremu <45821029+elielijah321@users.noreply.github.com> Date: Wed, 13 Dec 2023 15:05:52 +0000 Subject: [PATCH 4/6] remove boolean literal - code smell --- .../Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml | 6 +++--- .../Pages/Shared/_ProjectListRows.cshtml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml b/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml index 8b3aee2d3..d8e5a46dd 100644 --- a/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml +++ b/Dfe.PrepareConversions/Dfe.PrepareConversions/Pages/ProjectList/Index.cshtml @@ -51,9 +51,9 @@
---|
- - | +
---|
Application information | +