Don't raise error when shutting down sync services #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
force-pushed
the
handle-cancellation-in-sync
branch
from
0a92174 to
51d6ed4
Compare
gunndabad
force-pushed
the
handle-cancellation-in-sync
branch
from
51d6ed4 to
4c2daf4
Compare
MrKevJoy
approved these changes
Jan 4, 2024
gunndabad
force-pushed
the
handle-cancellation-in-sync
branch
from
4c2daf4 to
d554bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few errors in Sentry caused by
OperationCanceledExceptions inTrsDataSyncServicewhen the app is shutting down. This change prevents wrapping those exceptions so that they are correctly handled (and not logged).While the Sentry logs have only been for
TrsDataSyncServiceI've made the same change toDqtReportingServicetoo, since it's near-identical in its error handling and could see the same problem.