Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeown should clear enemy.army_controller_id #4753

Closed
ab9rf opened this issue Jun 26, 2024 · 2 comments
Closed

makeown should clear enemy.army_controller_id #4753

ab9rf opened this issue Jun 26, 2024 · 2 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented Jun 26, 2024

Based on this comment on discord, I did some code searches in 50.13 and discovered that, in at least some situations, when a unit is joined to a site its army_controller_id is set to -1 to indicate that it is no longer a part of an "army". makeown should probably do this. This appears to affect hostility determinations, based on other observations made in discord.

It may also be necessary to remove the unit and the unit's histfig from the army itself; whether this is needed requires further research.

@Crystalwarrior
Copy link
Contributor

Further research should also be done on what would get the "Expel" button to appear, because it appeared for intelligent wilderness creatures I makeown-ed, but not the goblin snatchers.

@myk002 myk002 added this to 50.14-r2 Oct 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in 50.14-r2 Oct 5, 2024
@myk002
Copy link
Member

myk002 commented Oct 5, 2024

Fixed by DFHack/scripts#1321

@myk002 myk002 closed this as completed Oct 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in 50.14-r2 Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants