Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: 为成就添加分类 #897

Closed
dyxa opened this issue Sep 4, 2023 · 8 comments · Fixed by #1972
Closed

[Feat]: 为成就添加分类 #897

dyxa opened this issue Sep 4, 2023 · 8 comments · Fixed by #1972
Assignees
@Lightczx
Labels
area-Achievement 成就管理 block-by-metadata 需要更新元数据 已完成 This issue is completed
Milestone
1.11.2

Comments

@dyxa
Copy link

dyxa commented Sep 4, 2023

背景与动机

便于完成能马上完成的成就

想要实现或优化的功能

将成就分为 是否通过每日委托完成的两类（通过勾选）
@dyxa dyxa added the 功能 label Sep 4, 2023
@dgp-bot dgp-bot bot moved this to 备忘录 in Snap Hutao Development Sep 4, 2023
@Lightczx Lightczx added the area-Achievement 成就管理 label Sep 4, 2023
@Masterain98 Masterain98 added the priority:low Not user noticeable; brand new feature request label Oct 18, 2023
@Lightczx
Copy link
Member

DGP-Studio/Snap.Metadata#3

@Lightczx Lightczx added the block-by-metadata 需要更新元数据 label Oct 20, 2023
This was referenced Jan 30, 2024
Closed
Closed
@Lightczx Lightczx mentioned this issue Feb 12, 2024
Open
66 tasks
@Lightczx
Copy link
Member

Tracked by #1394

@Lightczx Lightczx closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@dgp-bot dgp-bot bot removed the priority:low Not user noticeable; brand new feature request label Feb 12, 2024
@github-project-automation github-project-automation bot moved this from 备忘录 to 完成 in Snap Hutao Development Feb 12, 2024
@Masterain98
Copy link
Member

@Lightczx 元数据

https://github.com/Masterain98/Genshin_Regional_Quest_Achievement_ID/blob/main/DailyQuestAchievement.json

@Masterain98 Masterain98 reopened this Mar 7, 2024
@dgp-bot dgp-bot bot added the priority:low Not user noticeable; brand new feature request label Mar 7, 2024
@dgp-bot dgp-bot bot moved this from 完成 to 备忘录 in Snap Hutao Development Mar 7, 2024
qhy040404 added a commit that referenced this issue Sep 13, 2024
@qhy040404
#897 #1907
57e5739
@qhy040404 qhy040404 mentioned this issue Sep 13, 2024
Merged
1 task
@qhy040404 qhy040404 linked a pull request Sep 13, 2024 that will close this issue
impl achievement features #1972
Merged
1 task
@dgp-bot
Copy link

dgp-bot bot commented Sep 13, 2024

57e5739 已完成此议题

@dgp-bot dgp-bot bot added 已完成 This issue is completed 等待发布 This issue fix is going to be applied in the next release and removed priority:low Not user noticeable; brand new feature request labels Sep 13, 2024
@dgp-bot dgp-bot bot moved this from 备忘录 to 完成 in Snap Hutao Development Sep 13, 2024
@Mikachu2333
Copy link
Collaborator

感觉没能达到预期“能马上完成”。部分简易成就例如“「好烫！好烫！」”也属于“易完成”类型的，感觉可以再加一类

@Lightczx
Copy link
Member

感觉没能达到预期“能马上完成”。部分简易成就例如“「好烫！好烫！」”也属于“易完成”类型的，感觉可以再加一类

不考虑

@dgp-bot dgp-bot bot added this to the 1.11.2 milestone Sep 18, 2024
@dgp-bot
Copy link

dgp-bot bot commented Sep 18, 2024

包含解决该问题的程序版本 1.11.2 已发布。

@dgp-bot dgp-bot bot removed the 等待发布 This issue fix is going to be applied in the next release label Sep 18, 2024
@dgp-bot dgp-bot bot closed this as completed Sep 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topic.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Lightczx Lightczx

Labels
area-Achievement 成就管理 block-by-metadata 需要更新元数据 已完成 This issue is completed
Projects
Snap Hutao Development
Status: 完成
Milestone
1.11.2
Development

Successfully merging a pull request may close this issue.

impl achievement features DGP-Studio/Snap.Hutao
4 participants
@Masterain98 @dyxa @Lightczx @Mikachu2333