Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use ITK EIGEN configuration #1758

Closed
wants to merge 4 commits into from

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Feb 3, 2025

PR Description

In order to avoid issue on conflicting eigen version, this option allows to let use the ITK configuration of eigen (in link to issue like DGtalTools 537).
Thanks @phcerdan for the DGtalTools issue discussion and suggestions.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 3, 2025

Thanks a lot, @kerautret for the PR. As you may know, Bastien is working on a DGtal 2.0 version with many breaking changes.
Could you please create a new branch from the branch DGtal:main2.0, apply your changes and create a new PR targeting the main2.0branch ?

thx in advance

@kerautret
Copy link
Member Author

Thanks a lot, @kerautret for the PR. As you may know, Bastien is working on a DGtal 2.0 version with many breaking changes. Could you please create a new branch from the branch DGtal:main2.0, apply your changes and create a new PR targeting the main2.0branch ?

thx in advance

I see yes I do it thanks

@kerautret
Copy link
Member Author

done @dcoeurjo so closing this one ;)

@kerautret kerautret closed this Feb 3, 2025
@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 3, 2025

thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants