Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop: #warning preprocessor causes compile error on MSVC #472

Open
sevenc-nanashi opened this issue Oct 5, 2024 · 2 comments
Open

develop: #warning preprocessor causes compile error on MSVC #472

sevenc-nanashi opened this issue Oct 5, 2024 · 2 comments

Comments

@sevenc-nanashi
Copy link

MSVC does not support #warning, but DPF uses #warning in some places, thus the compile warning causes compile error on MSVC.

@falkTX
Copy link
Contributor

falkTX commented Oct 5, 2024

we need to have better CI tests for msvc to be able to detect these things. I dont use it myself, so need contributions to that.
but there is a minimal set of CI jobs with msvc already, and they dont fail... isnt invalid pragmas a warning? maybe you have warnings as errors?

@sevenc-nanashi
Copy link
Author

minimal set of CI jobs with msvc already, and they dont fail

I think it's because all examples are correct.
I encountered this situation by #defineing DISTRHO_PLUGIN_HAS_EMBED_UI as 1 on develop branch.
This situation activated this branch: https://github.com/DISTRHO/DPF/blob/develop/distrho/src/DistrhoPluginChecks.h#L146-148 , which includes the #warning preprocessor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants