Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit("", x) string not updated #18

Open
roland1977 opened this issue Feb 10, 2017 · 6 comments
Open

exit("", x) string not updated #18

roland1977 opened this issue Feb 10, 2017 · 6 comments

Comments

@roland1977
Copy link

If you do the exit() statement into your program it returns the value and the correct string. Then, if you start the program again and quits with ALT+X it shows the latest return string.

Issues is: the string will not be updated!

Example:
program exit_test;

begin
loop
if (key(_esc)) exit("Exited with the ESC key1", 0); end
frame;
end
end

@CicTec
Copy link
Contributor

CicTec commented Apr 25, 2017

Hello roland,

This problem only appears when running programs from the development environment, in the release version this does not happen.

Now the bug has been fixed, thanks for the report.

@MikeDX
Copy link
Collaborator

MikeDX commented Apr 26, 2017

Cictec is there a pull request for this fix?

@CicTec
Copy link
Contributor

CicTec commented Apr 26, 2017

Not yet Mike,

I'm running a re-format of all the core code for better bug fixes, then proceed to all bug fixes that are reported, once we finish, we'll get a pre-test build and when we confirm that all bugs are fixed well, we proceed with a single source code upload, instead of making multiple pull requests.

I think it is the best solution for now, but if you have a better idea, we can proceed in another way.

@MikeDX
Copy link
Collaborator

MikeDX commented Apr 26, 2017

A single pull request with lots of changes will be difficult to track and check the differences of. In collaborative projects it is better to havesmaller pull requests that solve a single problem than one large upload which solves many (obviously sometimes one small change may fix more than one bug).

@CicTec
Copy link
Contributor

CicTec commented Apr 26, 2017

Yes, but a re-format involve into all source code files of the core, are a lot of "changes" already.

I am recording in a worklog all the important changes and fixes where they were made, so that we can check it fast.
If this is not enough, i finish the refactor of the remaining files and proceed with the pull request of the one done so far.

@roland1977
Copy link
Author

nice, thanks for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants