Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deleting all elements from a tree #1137

Open
lukasdreyer opened this issue Jul 16, 2024 · 0 comments
Open

Enable deleting all elements from a tree #1137

lukasdreyer opened this issue Jul 16, 2024 · 0 comments
Labels
enhancement Enhances already existing code New feature Adds a new feature to the code priority: low Should be solved eventually workload: medium Would take a week or less

Comments

@lukasdreyer
Copy link
Collaborator

It is currently not supported to delete all elements of a global tree.
Some of the completely empty trees go missing during a partitioning step.

There is already a disabled test that fails, see t8_gtest_empty_global_tree

This problem probably occurs during the partition send step.

In t8_forest_partition_sendloop, we determine how many elements to send in total, and iterate over all procs that we need to send elements to.
In t8_forest_partition_fill_buffer, we iterate over all local trees, until all elements have been sent.

In the case that there is a tree afterwards, which had all its elements deleted, this tree will not be sent, and is therefore lost.

@lukasdreyer lukasdreyer added the Bug For a bug in the Code label Jul 16, 2024
@holke holke added priority: low Should be solved eventually enhancement Enhances already existing code New feature Adds a new feature to the code workload: medium Would take a week or less and removed Bug For a bug in the Code labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code New feature Adds a new feature to the code priority: low Should be solved eventually workload: medium Would take a week or less
Projects
None yet
Development

No branches or pull requests

2 participants