Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8code does not compile with -Wextra and/or -Wpedantic #1155

Open
jmark opened this issue Jul 17, 2024 · 3 comments
Open

t8code does not compile with -Wextra and/or -Wpedantic #1155

jmark opened this issue Jul 17, 2024 · 3 comments
Labels
cleanup Cleans the code enhancement Enhances already existing code priority: low Should be solved eventually workload: medium Would take a week or less

Comments

@jmark
Copy link
Collaborator

jmark commented Jul 17, 2024

Would be nice to fully to support these flags, too.

@jmark jmark added enhancement Enhances already existing code cleanup Cleans the code priority: low Should be solved eventually workload: medium Would take a week or less labels Jul 17, 2024
@lukasdreyer
Copy link
Collaborator

Those are the additional warnings that arise:

-Werror=unused-parameter, fixed by introducing [[maybe_unused]] https://en.cppreference.com/w/cpp/language/attributes/maybe_unused

-Werror=type-limits, fixed by removing the unnecessary unsigned int >= 0 assertion

-Werror=implicit-fallthrough=, fixed by not allowing switch statements to fall through

-Werror=ignored-qualifiers, fixed by removing const return qualifier

@holke
Copy link
Collaborator

holke commented Jul 22, 2024

#1158 fixes parts of the fallthroughs.

@holke
Copy link
Collaborator

holke commented Jul 22, 2024

#1118 is related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleans the code enhancement Enhances already existing code priority: low Should be solved eventually workload: medium Would take a week or less
Projects
None yet
Development

No branches or pull requests

3 participants