Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Use constant string for http error response #517

Closed
howjmay opened this issue Mar 16, 2020 · 1 comment
Closed

Use constant string for http error response #517

howjmay opened this issue Mar 16, 2020 · 1 comment
Labels
A-router Area - API routes C-refactor Category - Improvement help wanted Community contributors are welcome P-medium Priority - Medium, not hurry but needed

Comments

@howjmay
Copy link
Contributor

howjmay commented Mar 16, 2020 •
edited
Loading

Allocating new string with for a macro string every time is somehow not efficient and may error-prone. It seems it is better to make response message be composed of read-only const char*

See discussion in #516 (comment)
@howjmay howjmay added A-router Area - API routes C-refactor Category - Improvement P-medium Priority - Medium, not hurry but needed help wanted Community contributors are welcome labels Mar 16, 2020
@howjmay
Copy link
Contributor Author

howjmay commented Mar 17, 2020

Duplicated in #519

@howjmay howjmay closed this as completed Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-router Area - API routes C-refactor Category - Improvement help wanted Community contributors are welcome P-medium Priority - Medium, not hurry but needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@howjmay