Review: Bonus Score System and Likehillihood

[SurfingNerd]

During investigating of the problems of alpha5, i noticed strange results for Likehillihood and Bonus Scores.

starting with this comment:
DMDcoin/alpha4#3 (comment)

[axel-muller]

Logs provided in DMDcoin/alpha4#3 (comment) looks like validator connectivity score (according to script in honey-badger-testing it is), not a bonus score:
https://github.com/DMDcoin/honey-badger-testing/blob/29edcf58ce950acb1f2b1760efd98b7a0422a85f/src/contracts/printContractDetails.ts#L95-L98

Connectivity score is 0 by default and only increase if validator was reported for missing connectivity.

Bonus score minimum value is 1 by design, reference:

diamond-contracts-core/contracts/BonusScoreSystem.sol

Lines 194 to 200 in 5f19531

	/// @dev Get current validator score.
	/// @param mining Validator mining address.
	/// @return value current validator score.
	function getValidatorScore(address mining) public view returns (uint256) {
	// will return current validator score or MIN_SCORE if score has not been recorded before.
	return Math.max(_validatorScore[mining], MIN_SCORE);
	}

[SurfingNerd]

thank you