Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Allowed Problem: Delaying Key Generation Transactions #22

Open
SurfingNerd opened this issue Jun 21, 2021 · 1 comment
Open

Not Allowed Problem: Delaying Key Generation Transactions #22

SurfingNerd opened this issue Jun 21, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@SurfingNerd
Copy link
Collaborator

currently we sometimes have a timing issue, when Node A becomes a pending validator, and immediately sends it's PART transaction.
Sometimes Node B, sees this transaction, checks if the node is allowed to do that, while not having imported the block yet, that marks Node A as pending validator.

Proposed Solution:
Instead of being that eager to send the PART transaction as fast as possible, Node A could just wait for a small delay, so Node B gets a fair chance to import the Block that marks Node A as pending validator.

This should hick up only a few unit tests that need to get adopted, and increase the timespan by a few seconds to write the contributions.
The Timing Issue in unit tests might be solvable with #2

@dforsten
Copy link
Collaborator

Dev Notes:

The transaction sending delay needs to be introduced at two points in the Key Generation Phase:

  1. When the Key Generation Phase starts
  2. When all Parts have been written

@SurfingNerd
Are the blocks at which these transitions start available through a function call in the POSDAO contracts?

SurfingNerd added a commit that referenced this issue Aug 22, 2021
@SurfingNerd SurfingNerd added the bug Something isn't working label Nov 4, 2021
@SurfingNerd SurfingNerd added this to the v4.0 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants