Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and resize images explicitly #138

Open
csmith opened this issue Mar 7, 2019 · 0 comments
Open

Download and resize images explicitly #138

csmith opened this issue Mar 7, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@csmith
Copy link
Member

csmith commented Mar 7, 2019

At the minute for inline images we just lob an Image node in the graph and let JavaFX sort it out.

We should really be downloading and resizing the image first, and if both of those steps succeed /then/ show it. We could maybe show a placeholder initially and edit it afterwards.

This will make it nicer if someone links to a *.png/gif/jpg/etc url that's not actually an image, and should improve the quality of the resizing which is pretty dire.

@csmith csmith added the enhancement New feature or request label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant