Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StripQuoteTag utility method and use it when posting to journal (… #1174

Merged

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Nov 22, 2024

Description of PR...

When posting to DNN journal, removes "quoted" portion from a reply

Changes made

How did you test these updates?

Local install.

Before this pull request, you don't actually see what the responder is posting -- just the portion being "quoted":
image

This is the actual reply. This pull request will remove the "Posted by..." part and just show the actual reply:
image

What the journal looks like after this pull request:
image

This works for editing an existing reply as well.

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #748
Close #1158
Close #1159

…NNCommunity#748)

Use DNN RegexUtil.GetCachedRegex() for additional regex replacements (DNNCommunity#1158)
Use System.Net.WebUtility.*Encode/*Decode rather than System.Web.HttpUtility & remove PortalSecurity calls (DNNCommunity#1159)
Minor text/string utility refactoring
…NNCommunity#748)

Use DNN RegexUtil.GetCachedRegex() for additional regex replacements (DNNCommunity#1158)
Use System.Net.WebUtility.*Encode/*Decode rather than System.Web.HttpUtility & remove PortalSecurity calls (DNNCommunity#1159)
Minor text/string utility refactoring
@johnhenley johnhenley added enhancement New feature or request technical debt Issue that doesn't directly affect usability but will improve technical debt posture performance An update likely to improve site performance usability Issues with UI labels Nov 22, 2024
@johnhenley johnhenley added this to the 08.02.00 milestone Nov 22, 2024
@johnhenley johnhenley self-assigned this Nov 22, 2024
@johnhenley johnhenley merged commit 8c1cd8a into DNNCommunity:dev Nov 22, 2024
1 check passed
@johnhenley johnhenley deleted the dev82/optimize-journal-content-748 branch November 22, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance An update likely to improve site performance technical debt Issue that doesn't directly affect usability but will improve technical debt posture usability Issues with UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASK: Refactor script/tag removal TASK: Update regex usage ENH: Optimize what gets posted to the journal
1 participant