Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Replace forum list & delete sprocs with DAL2 #1164

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Move some forum table CRUD methods from stored procedures to use DAL2 controller/object

Changes made

  • Update code using sproc methods to use DAL2 controller/object
  • Mark for deprecation
    • Forums_Delete
    • Forums_List
    • Forum_ConfigCleanUp

NOTE: Leaving Forum_Save for future.

How did you test these updates?

local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #1160

@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture labels Nov 14, 2024
@johnhenley johnhenley added this to the 08.02.00 milestone Nov 14, 2024
@johnhenley johnhenley self-assigned this Nov 14, 2024
@johnhenley johnhenley merged commit f46bfd1 into DNNCommunity:dev Nov 14, 2024
1 check passed
@johnhenley johnhenley deleted the dev82/dal2-forums-1160 branch November 14, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASK: Update remaining forum list sproc calls to DAL2
1 participant