Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: replace forum group delete stored procedure with DAL2 #1165

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Move some forum group table CRUD methods from stored procedures to use DAL2 controller/object

Changes made

  • Update code using sproc methods to use DAL2 controller/object
  • Pass group settings key to Groups_Save rather than calculate it in stored procedure
  • Mark for deprecation
    • Groups_Delete

NOTE: Leaving Groups_Save for future.

How did you test these updates?

local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #1162

@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture labels Nov 14, 2024
@johnhenley johnhenley added this to the 08.02.00 milestone Nov 14, 2024
@johnhenley johnhenley self-assigned this Nov 14, 2024
@johnhenley johnhenley merged commit ea7e56a into DNNCommunity:dev Nov 14, 2024
1 check passed
@johnhenley johnhenley deleted the dev82/dal2-groups-1162 branch November 14, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASK: Update remaining forum group list sproc calls to DAL2
1 participant